Skip to content

Conversation

@yschimke
Copy link
Member

@yschimke yschimke commented Oct 9, 2017

No description provided.

@yschimke
Copy link
Member Author

yschimke commented Oct 9, 2017

@robertroeser I'd like to discuss the availability aspect with you. To my mind, an unavailable connection should result in visible exceptions through the normal requestResponse error handling, not ignored or sent to the connection error handler (only).

@robertroeser
Copy link
Member

@yschimke we can try throwing errors. I think I did this before and it lead to some issues where the side effects were causing errors - or we were sending frames that weren't necessary without checking if the connection was still open. It might be better now.

@yschimke
Copy link
Member Author

@robertroeser any blocker to landing this?

@robertroeser robertroeser merged commit c8a5ed7 into rsocket:1.0.x Oct 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants